Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription ......................................................................
Patch Set 20: (2 comments) https://gerrit.ovirt.org/#/c/36368/20/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 533: """ Line 534: In order to process message we need to set message Line 535: handler which is responsible for processing jsonrpc Line 536: content of the message. Currently there are 2 handlers: Line 537: JsonRpcClient and JsonRpcServer. > what do I pass , the class itself or the _handleMessage function of it? Above classes handle messages depending on which side of communication they are. I will update the docstring. Line 538: """ Line 539: def set_message_handler(self, handler): Line 540: self._message_handler = handler Line 541: https://gerrit.ovirt.org/#/c/36368/20/tests/jsonRpcTests.py File tests/jsonRpcTests.py: Line 84 Line 85 Line 86 Line 87 Line 88 > this is new.. was it intend? yes. this is no longer needed. -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
