Francesco Romani has posted comments on this change. Change subject: vm: Save state only if disk was updated ......................................................................
Patch Set 11: Code-Review+1 the change looks correct and helpful. Considering my experience taming the vm.py horrors, it is possible that this change also uncovers bugs due our duplicate data between device conf and device object, but that's actually *welcome*, so we can squash them, and hopefully make progress through the long-desired unification. -- To view, visit https://gerrit.ovirt.org/40219 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I081a0c7f544a003665bd02769489d601bdf7a86b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
