Nir Soffer has posted comments on this change. Change subject: vm: Delete Drive.diskReplicate before saving config ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/40220/11//COMMIT_MSG Commit Message: Line 10: destination volume or keeping the source volume, Drive.diskReplicate Line 11: must be deleted, to ensure that high watermark monitoring is correct. Line 12: Line 13: The current code could fail to delete diskReplicate if the disk was not Line 14: found in Vm.conf, or saving state failed. This could lead to incorrect > correct, even though I'd be already worried by the mismatch between drive d Francesco, what can we do if saving state failed other than fail the current request? We have two options - have incorrect in-memory state, which can lead to breaking of extension mechanism, but being consistent with on-disk state, or have correct in-memory state synchronized with libvirt state, and incorrect on-disk state. The only way out of this is eliminating the on-disk state, and using libvirt state, or minimizing the on-disk state only to the state which is not kept by libvirt. Line 15: extend requests for non-existent volume. Line 16: Line 17: Change-Id: I3112f94a4877e28057497749938aa8c3d7771d30 -- To view, visit https://gerrit.ovirt.org/40220 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3112f94a4877e28057497749938aa8c3d7771d30 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
