Nir Soffer has posted comments on this change. Change subject: jsonrpc: filter params while logging secure method invocation ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/40961/3/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 458: 'VM.desktopLogin', Line 459: 'VM.setTicket' Line 460: 'VM.updateDevice') Line 461: Line 462: SECURE_RETURN = ('Host.getDeviceList') This is not a tuple with single item, but a string. The matching will succeed, but it is very fragile. Should be: ('Host.getDeviceList',) Line 463: Line 464: def __init__(self, bridge, threadFactory=None): Line 465: self._bridge = bridge Line 466: self._workQueue = Queue() -- To view, visit https://gerrit.ovirt.org/40961 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
