Nir Soffer has posted comments on this change. Change subject: v2v: Job related actions ......................................................................
Patch Set 16: (1 comment) My comment was lost on an older version. https://gerrit.ovirt.org/#/c/39361/16/client/vdsClient.py File client/vdsClient.py: Line 1925: validateArgTypes(args, [str], requiredArgsNumber=1) Line 1926: status = self.s.getConvertedVm(args[0]) Line 1927: if status['status']['code'] == 0: Line 1928: print(status['ovf']) Line 1929: return status['status']['code'], status['status']['message'] Lets use same terms you used in convertExternalVm: status -> response Same in all functions. Line 1930: Line 1931: def abortV2VJob(self, args): Line 1932: validateArgTypes(args, [str], requiredArgsNumber=1) Line 1933: status = self.s.abortV2VJob(args[0]) -- To view, visit https://gerrit.ovirt.org/39361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a58583a88e2f17ce0847626cd601efbe1a00ac9 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
