Ido Barkan has posted comments on this change. Change subject: sampling: hoststats: rationalize getInterfaceStats ......................................................................
Patch Set 4: Code-Review-1 (1 comment) -1 for visibility (comments inside) https://gerrit.ovirt.org/#/c/40426/4/vdsm/virt/sampling.py File vdsm/virt/sampling.py: less messy indeed! I think that since you touch get() you should delegate it's other task to another self documenting methods like stats.update(_getCpuStats()). Maybe in a following patch, but not necessarily. -- To view, visit https://gerrit.ovirt.org/40426 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I556149271fb2786a6ff7341642989ea767eb2392 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
