Francesco Romani has posted comments on this change. Change subject: sampling: hoststats: switch to SampleWindow ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/40428/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-14 12:26:43 +0200 Line 6: Line 7: sampling: hoststats: switch to SampleWindow Line 8: Line 9: HostStatsThread has ts own sampling storage code, > it's Done Line 10: like VmStatsThread had before the introduction of Line 11: the SampleWindow class. Line 12: Line 13: The API of SampleWindow covers the HostStatsThread needs, https://gerrit.ovirt.org/#/c/40428/6/vdsm/virt/sampling.py File vdsm/virt/sampling.py: Line 612: 'cpuUserVdsmd': 0.0, Line 613: 'elapsedTime': int(time.time() - self.startTime) Line 614: } Line 615: Line 616: hs0, hs1, _ = self._samples.stats() > while you are here: maybe rename to "first_sample, last_sample" or somethin good point, will do in a followup patch. Line 617: # we need a different interval, see below Line 618: if hs0 is None or hs1 is None: Line 619: return stats Line 620: -- To view, visit https://gerrit.ovirt.org/40428 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ec5712ee1fb69ed3d8dbc28ca4e6511998270c9 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
