Piotr Kliczewski has posted comments on this change. Change subject: stomp: introduction of header constants ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/41069/1/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 59: stomp.Command.UNSUBSCRIBE: self._cmd_unsubscribe} Line 60: Line 61: def _cmd_connect(self, dispatcher, frame): Line 62: self.log.info("Processing CONNECT request") Line 63: version = frame.headers.get("accept-version", None) > use new header, please Done Line 64: if version != "1.2": Line 65: res = stomp.Frame(stomp.Command.ERROR, None, "Version unsupported") Line 66: else: Line 67: res = stomp.Frame(stomp.Command.CONNECTED, {"version": "1.2"}) Line 74: cy = max(cy, 1000) Line 75: Line 76: # The server can send a heart-beat every cy ms and doesn't want Line 77: # to receive any heart-beat from the client. Line 78: res.headers["heart-beat"] = "%d,0" % (cy,) > here, too. Done Line 79: dispatcher.setHeartBeat(cy) Line 80: Line 81: dispatcher.send_raw(res) Line 82: self._reactor.wakeup() -- To view, visit https://gerrit.ovirt.org/41069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibecb4f5ebaa962861ae5836a6594ad3a0f8c166c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
