Francesco Romani has uploaded a new change for review. Change subject: virt: don't log password in update graphic device ......................................................................
virt: don't log password in update graphic device updateDevice invoked against a graphics device allows Engine (or any other caller) to change the SPICE ticket. This patch make sure the ticket is not logged. Change-Id: I4c3d318a16eb4d1b10a12f650ba957057e090532 Signed-off-by: Francesco Romani <[email protected]> --- M vdsm/rpc/BindingXMLRPC.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/41073/1 diff --git a/vdsm/rpc/BindingXMLRPC.py b/vdsm/rpc/BindingXMLRPC.py index fbce42d..80136c1 100644 --- a/vdsm/rpc/BindingXMLRPC.py +++ b/vdsm/rpc/BindingXMLRPC.py @@ -1159,6 +1159,12 @@ elif f.__name__ == 'convertExternalVm': if len(args) > 3: displayArgs = args[:2] + ('****',) + args[3:] + elif f.__name__ == 'vmUpdateDevice': + if len(args) == 2 and args[1].get( + 'deviceType', '') == 'graphics': + devParams = args[1].copy() + devParams['password'] = '****' + displayArgs = args[0] + [devParams] # Logging current call logStr = 'client [%s]::call %s with %s %s' % \ -- To view, visit https://gerrit.ovirt.org/41073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4c3d318a16eb4d1b10a12f650ba957057e090532 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
