Francesco Romani has posted comments on this change. Change subject: properties: Add properties module ......................................................................
Patch Set 3: Code-Review+1 (2 comments) yes, this is cool. It reminds me of definitions of columns in Model classes in ORM, but even nicer. This can solve the abuse of __slots__ we are doing in device classes. Very nicely done, I really like it. The only minor concern is if the 'properties' is really a suitable name. Seems a bit too generic, and I don't have any really better suggestion. https://gerrit.ovirt.org/#/c/40822/3/lib/vdsm/properties.py File lib/vdsm/properties.py: Line 1: """ missing license boilerplate. I don't really mind, but legal can :) Line 2: properties - reusable properties Line 3: Line 4: Properties are reusable objects similar to builtin property() function, adding Line 5: input validation and initialization grantees. Line 1: """ Line 2: properties - reusable properties Line 3: Line 4: Properties are reusable objects similar to builtin property() function, adding Line 5: input validation and initialization grantees. guarantees? Line 6: Line 7: Line 8: This module provides the following properties: Line 9: -- To view, visit https://gerrit.ovirt.org/40822 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I62175172dddce7f84319e3c8669747994e06a697 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
