Nir Soffer has posted comments on this change. Change subject: jsonrpc: rename setMessageHandler method for pep8 compliance ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/41065/3/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: If we go in the pep8 direction, lets rename this module to stompreactor.py, or even better stomp.py. We have many stomp classes here, and a tiny reactor class; it is clear that this module is *not* about stomp reactor :-) Line 1: # Copyright (C) 2014 Saggi Mizrahi, Red Hat Inc. Line 2: # Line 3: # This program is free software; you can redistribute it and/or modify Line 4: # it under the terms of the GNU General Public License version 2 as https://gerrit.ovirt.org/#/c/41065/3/vdsm/rpc/BindingJsonRpc.py File vdsm/rpc/BindingJsonRpc.py: Same fro this module name - jsonrpcbinding.py or better jsonrpc.py Line 1: # VDSM JsonRPC Server Line 2: # Copyright (C) 2012 Adam Litke, IBM Corporation Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/41065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iefa9e04dd9f8e52e3f4edcc0a1dadc4845d9f74f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
