Dan Kenigsberg has posted comments on this change. Change subject: network: Recognize macvlans as fake devices ......................................................................
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40608/1/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 219: """ Line 220: Returns True iff vdsm config marks the DUMMY or VETH dev to be reported Line 221: as NIC. Line 222: """ Line 223: if self.isDUMMY() or self.isVETH() or self.isMACVLAN(): please note that macvlans are used by libvirt to connect VMs to VFs (used by our vmfex hooks). I think that by default they would not match the _fakeNics glob, so they would not be reported as such. Line 224: return anyFnmatch(self.name, self._fakeNics) Line 225: return False Line 226: Line 227: def isNICLike(self): -- To view, visit https://gerrit.ovirt.org/40608 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8193039478020246cac81b86406dfd9dbebed7ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Anatoly Litovsky <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
