Ondřej Svoboda has posted comments on this change. Change subject: veth: introduce a context manager to create and destroy a veth pair ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38945/2//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-03-13 19:58:20 +0100 Line 4: Commit: Ondřej Svoboda <osvob...@redhat.com> Line 5: CommitDate: 2015-05-14 19:14:12 +0200 Line 6: Line 7: veth: introduce a context manager to create and destroy a veth pair > you are just moving it to another place, not introducing it, right? Even though vethIf is being removed, most of veth.pair's code originates from veth.create. From veth module's POV I am introducing it and making use of it in netinfotests. The wording was not very important to me :-) Line 8: Line 9: Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b -- To view, visit https://gerrit.ovirt.org/38945 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58688d23ea059ced35c77fd1c4262543582ae53b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
