Yeela Kaplan has posted comments on this change. Change subject: [WIP]migration: Start using migrate3 instead of migrate2 ......................................................................
Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/41101/2/vdsm/virt/migration.py File vdsm/virt/migration.py: Line 335: # if we call stop() and libvirt migrateToURI3 didn't start Line 336: # we may return migration stop but it will start at libvirt Line 337: # side Line 338: self._preparingMigrationEvt = False Line 339: if not self._migrationCanceledEvt: > Please add a Done Line 340: params = {'migrate_uri': muri, Line 341: 'destination_xml': None, Line 342: 'destination_name': None, Line 343: 'bandwidth': maxBandwidth} Line 341: 'destination_xml': None, Line 342: 'destination_name': None, Line 343: 'bandwidth': maxBandwidth} Line 344: Line 345: flags = libvirt.VIR_MIGRATE_LIVE |\ > please open a parenthesis - it is much nicer than backslashes. Done Line 346: libvirt.VIR_MIGRATE_PEER2PEER |\ Line 347: (libvirt.VIR_MIGRATE_TUNNELLED if Line 348: self._tunneled else 0) |\ Line 349: (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if -- To view, visit https://gerrit.ovirt.org/41101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I57a1d9aeb796998c5100e0c2ec3fb05e775022ed Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
