Nir Soffer has posted comments on this change. Change subject: stomp: creation of outbox class ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/41067/2/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 278: except IndexError: Line 279: return None Line 280: Line 281: Line 282: class Outbox(object): > Initially we used deque and I was asked to wrap/adopt it and share this imp I was asked is not a technical argument. Please explain why using this wrapper is needed. Line 283: Line 284: def __init__(self): Line 285: self._outbox = deque() Line 286: -- To view, visit https://gerrit.ovirt.org/41067 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2020b05393daeafaed73f628cf441305a2d52354 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
