Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/40478/3/vdsm/network/configurators/ifcfg.py File vdsm/network/configurators/ifcfg.py: Line 763: rc, _, _ = utils.execCmd([constants.EXT_IFDOWN, iface], raw=True) Line 764: return rc Line 765: Line 766: Line 767: def _ifup(iface_name): I can live with _exec_ifup, or maybe _ifup_blocking(). Line 768: """Bring up an interface""" Line 769: rc, out, err = utils.execCmd([constants.EXT_IFUP, iface_name], raw=False) Line 770: Line 771: if rc != 0: Line 773: # contains the error reason. Line 774: raise ConfigNetworkError(ERR_FAILED_IFUP, out[-1] if out else '') Line 775: Line 776: Line 777: def _ifup_nonblocking(iface_name, async=False): > You are right, it is only capable of being non-blocking, if asked to. Done Line 778: if async: Line 779: # wait for dhcp in another thread, so vdsm won't get stuck (BZ#498940) Line 780: t = threading.Thread(target=_ifup, name='ifup-waiting-on-dhcp', Line 781: args=(iface_name,)) -- To view, visit https://gerrit.ovirt.org/40478 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
