Dima Kuznetsov has posted comments on this change. Change subject: modify safelease executable path ......................................................................
Patch Set 3: Code-Review-1 We should not hardcode libexec paths if we plan to ship packages outside fedora derived distros. My Ubuntu Trusty server does not have such path (and I think Debians neither).. It also makes much sense to move safelease into the $PATH bow. When it was packaged as part of VDSM, and only VDSM used it, it made sense to put it into libexec as it was an executable internal to the other code, but not since it became independently packaged utility, you wouldn't expect anyone who installs it to run it with absolute path from a much less standard location. -- To view, visit https://gerrit.ovirt.org/41024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief298fe08e3b737c5c9f404675a15da4b026ca21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
