Nir Soffer has posted comments on this change. Change subject: reactor: using single instance ......................................................................
Patch Set 9: (3 comments) Nice! https://gerrit.ovirt.org/#/c/40170/9//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-04-22 17:02:45 +0200 Line 4: Commit: pkliczewski <[email protected]> Line 5: CommitDate: 2015-05-19 15:00:00 +0200 Line 6: Line 7: reactor: using single instance Can you give more context why this change is needed, and how are we going to use the single reactor? Line 8: Line 9: Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 https://gerrit.ovirt.org/#/c/40170/9/vdsm/clientIF.py File vdsm/clientIF.py: Line 24 Line 25 Line 26 Line 27 Line 28 Please import the Reactor here. Line 54: _glusterEnabled = True Line 55: except ImportError: Line 56: _glusterEnabled = False Line 57: Line 58: from yajsonrpc.betterAsyncore import Reactor Libraries should be imported before vdsm internal modules. Line 59: Line 60: Line 61: class clientIF(object): Line 62: """ -- To view, visit https://gerrit.ovirt.org/40170 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
