Dan Kenigsberg has posted comments on this change.

Change subject: netlink: make relative imports PY3 compatible
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40883/1/lib/vdsm/netlink/monitor.py
File lib/vdsm/netlink/monitor.py:

Line 14: # along with this program; if not, write to the Free Software
Line 15: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 
02110-1301 USA
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Would you add here

 from __future__ import absolute_import

so that this kind of error would not repeat in this file?
Line 19: from contextlib import closing, contextmanager
Line 20: from ctypes import CFUNCTYPE, c_int, c_void_p, py_object
Line 21: import Queue
Line 22: import logging


-- 
To view, visit https://gerrit.ovirt.org/40883
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43f01393790283eca5118e6e492eef1f7e6eb5c0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to