Dan Kenigsberg has posted comments on this change. Change subject: shell_helper: fix _latest_version as all packages are now noarch ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41188/1/contrib/shell_helper File contrib/shell_helper: Line 4: Line 5: VDSM_DIR=~/code/vdsm Line 6: Line 7: _latest_version() { Line 8: ls ~/rpmbuild/RPMS/noarch/ -t -w 1 | head -1 | perl -pe 's|^.*?git|git|' | perl -pe 's|\..*$||' can you put "*" here instead? just in case we are compelled to revert the recent move to "noarch". Line 9: } Line 10: Line 11: _latest_rpms() { Line 12: local VERSION=$(_latest_version) -- To view, visit https://gerrit.ovirt.org/41188 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c42c88978eed4edb1d04db3ff676c0c10ac8e8e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
