Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Add required information to replica dict ......................................................................
vm: Add required information to replica dict During LSM between mixed domain types, we need more information in the replica dict for creating destination disk xml and extending block-based replica. We keep the replica dict instead of dstDisk, and we also log it in error messages, since it contains more useful info. Since we must set the replica before preparing the volume, and we need the prepared path for getting the disk type, we persist the replica again after adding the replication info. Change-Id: If28c9e6d084fd27857ff9da2c024d8798f375cbd Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40024 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Federico Simoncelli <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 33 insertions(+), 4 deletions(-) Approvals: Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40024 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If28c9e6d084fd27857ff9da2c024d8798f375cbd Gerrit-PatchSet: 17 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
