Piotr Kliczewski has posted comments on this change. Change subject: stomp: subscription cleanup when connection lost ......................................................................
Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/39969/11/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 145: dispatcher.connection) Line 146: return Line 147: Line 148: try: Line 149: self._remove_subscription(self._sub_ids.pop(sub_id)) > You are hiding a KeyError raised in _remove_subscription() Done Line 150: except KeyError: Line 151: self.log.debug("No subscription for %s id", Line 152: sub_id) Line 153: return -- To view, visit https://gerrit.ovirt.org/39969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff05e4ff9d336dbfddf80002bad5bcd0dbac697f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
