Yaniv Bronhaim has posted comments on this change. Change subject: Configure libvirt to generate VM's core dumps ......................................................................
Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41072/3/init/systemd/unlimited-core.conf File init/systemd/unlimited-core.conf: Line 1: [Service] don't you want to specify that this additional conf file is installed by vdsm? https://gerrit.ovirt.org/#/c/41072/3/vdsm.spec.in File vdsm.spec.in: Line 800: %if 0%{?with_systemd} Line 801: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \ Line 802: %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf Line 803: install -Dm 0644 init/systemd/unlimited-core.conf \ Line 804: %{buildroot}%{_sysconfdir}/systemd/system/libvirtd.service.d/unlimited-core.conf won't we delete that file during uninstall? Line 805: %endif Line 806: Line 807: %if 0%{?rhel} Line 808: # This is not commonplace, but we want /var/log/core to be a world-writable -- To view, visit https://gerrit.ovirt.org/41072 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
