Dima Kuznetsov has posted comments on this change. Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41144/6/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 103: # exist (el7, fedora, debian), all is well. Line 104: if hasattr(service, '_chkconfigList'): Line 105: if service._chkconfigList('libvirtd'): Line 106: ret = NOT_CONFIGURED Line 107: Please don't access private service _methods. Either wrap with public ones that don't require hasattr checks before access or make this one public. Line 108: if ret == NOT_SURE: Line 109: sys.stdout.write("libvirt is already configured for vdsm\n") Line 110: else: Line 111: sys.stdout.write("libvirt is not configured for vdsm yet\n") -- To view, visit https://gerrit.ovirt.org/41144 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
