Dan Kenigsberg has submitted this change and it was merged. Change subject: models, configurators: replace the internal 'async' flag with blockingdhcp ......................................................................
models, configurators: replace the internal 'async' flag with blockingdhcp DHCP is queried asynchronously in usual situations so it is better to use 'blockingdhcp' which is a flag that signals some exceptional flow (network restoration, for example). blockingdhcp is also a part of the API so now there is direct correspondence between network configurators' code and the API. Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Signed-off-by: Ondřej Svoboda <osvob...@redhat.com> Reviewed-on: https://gerrit.ovirt.org/40456 Continuous-Integration: Jenkins CI Reviewed-by: Ido Barkan <ibar...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/network/configurators/__init__.py M vdsm/network/configurators/dhclient.py M vdsm/network/configurators/ifcfg.py M vdsm/network/models.py 4 files changed, 16 insertions(+), 20 deletions(-) Approvals: Ido Barkan: Looks good to me, but someone else must approve Ondřej Svoboda: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/40456 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e60040320d65ddbc4146a31c02c388ddad13ea9 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
