Dan Kenigsberg has posted comments on this change. Change subject: patch to avoid using upstarts when libvirtd.upstart not exist ......................................................................
Patch Set 3: Code-Review+2 (1 comment) https://gerrit.ovirt.org/#/c/41573/3/lib/vdsm/tool/configurators/libvirt.py File lib/vdsm/tool/configurators/libvirt.py: Line 134: cfile['path'] for cfile in self.FILES.values() Line 135: if cfile['persisted'] Line 136: ] Line 137: Line 138: def _isUpstartAvailable(self): nit: functions beginning with "is" should return a boolean. this function is more _find_upstart_script(). But never mind. Line 139: def iterateLibvirtFiles(): Line 140: ts = rpm.TransactionSet() Line 141: for name in ['libvirt', 'libvirt-daemon']: Line 142: for matches in ts.dbMatch('name', name): -- To view, visit https://gerrit.ovirt.org/41573 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c6daf8650927e05357a6f4e35312365b0138452 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Fabian Deutsch <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
