Ondřej Svoboda has posted comments on this change.

Change subject: networkTests: stop NetworkManager from managing devices using 
NM_CONTROLLED=no
......................................................................


Patch Set 20:

(1 comment)

An answer, but not so thorough for today.

https://gerrit.ovirt.org/#/c/37037/20/tests/functional/networkmanager.py
File tests/functional/networkmanager.py:

Line 38: toggle_managed(iface, True)
The simple reason why I let NM manage the iface is that you can see in the logs 
it was happy to take over control.

I believe (but don't have time today to check) that if we don't let NM manage 
the iface before removing it – and create it anew, NM would still refuse to 
manage it. It probably has some _runtime_ database of its "connections" (the 
term means "profiles" in NM parlance).


-- 
To view, visit https://gerrit.ovirt.org/37037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc8ea9e0b0d410203ed3045e735c9450eee316ae
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to