Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: Add _findDriveConfigByName() helper ......................................................................
vm: Add _findDriveConfigByName() helper The new helper eliminates duplicate code looking up drive configuration dict in Vm.conf in 4 methods. Change-Id: Ib3a59a2b798650035870c335ed7c949e2bd431d0 Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40217 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Dan Kenigsberg <[email protected]> Continuous-Integration: Dan Kenigsberg <[email protected]> --- M vdsm/virt/vm.py 1 file changed, 25 insertions(+), 34 deletions(-) Approvals: Nir Soffer: Verified Dan Kenigsberg: Looks good to me, approved; Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40217 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib3a59a2b798650035870c335ed7c949e2bd431d0 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
