Piotr Kliczewski has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout ......................................................................
Patch Set 13: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/38806/13/tests/Makefile.am File tests/Makefile.am: Line 22: Line 23: SUBDIRS = \ Line 24: functional \ Line 25: devices \ Line 26: pki \ Why do we still need this change? Line 27: $(NULL) Line 28: Line 29: device_modules = \ Line 30: devices/parsing/complex_vm_tests.py \ https://gerrit.ovirt.org/#/c/38806/13/tests/pki/Makefile.am File tests/pki/Makefile.am: Line 1: # Is this file still needed? Line 2: # Copyright 2015 Red Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify Line 5: # it under the terms of the GNU General Public License as published by https://gerrit.ovirt.org/#/c/38806/13/tests/run_tests_local.sh.in File tests/run_tests_local.sh.in: Line 6: if [ ! -f @top_srcdir@/tests/server.crt ] || [ ! -f @top_srcdir@/tests/server.csr ] || [ ! -f @top_srcdir@/tests/server.key ] || [ ! -f @top_srcdir@/tests/other.crt ] || [ ! -f @top_srcdir@/tests/other.csr ] || [ ! -f @top_srcdir@/tests/other.key ]; then Line 7: @top_srcdir@/tests/makecert.sh Line 8: fi Line 9: Line 10: #cp @top_srcdir@/tests/server.key @top_srcdir@/tests/pki/keys/vdsmkey.pem What is the reason for these comments? Line 11: #cp @top_srcdir@/tests/server.crt @top_srcdir@/tests/pki/certs/vdsmcert.pem Line 12: #cp @top_srcdir@/tests/server.crt @top_srcdir@/tests/pki/certs/cacert.pem Line 13: https://gerrit.ovirt.org/#/c/38806/13/vdsm.spec.in File vdsm.spec.in: Line 1316: %defattr(-, root, root, -) Line 1317: %dir %{_datadir}/%{vdsm_name}/tests Line 1318: %dir %{_datadir}/%{vdsm_name}/tests/functional Line 1319: %dir %{_datadir}/%{vdsm_name}/tests/devices Line 1320: %dir %{_datadir}/%{vdsm_name}/tests/pki do we still need pki dir? Line 1321: %dir %{_datadir}/%{vdsm_name}/tests/pki/certs Line 1322: %dir %{_datadir}/%{vdsm_name}/tests/pki/keys Line 1323: %{_datadir}/%{vdsm_name}/tests/*.py* Line 1324: %{_datadir}/%{vdsm_name}/tests/cpu_info.out -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 13 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
