Yeela Kaplan has posted comments on this change. Change subject: stomp: add an option to create a stomp client ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/38491/10/vdsm/clientIF.py File vdsm/clientIF.py: Line 448: json_binding = self.bindings['jsonrpc'] Line 449: except KeyError: Line 450: raise RuntimeError("json rpc server is not available") Line 451: reactor = json_binding.reactor Line 452: stompClient = reactor.createClient(client_socket) > what is the issue that you see during client creation? I'm sorry, but I don't think I understand your comment.. can you explain the issue you're referring to? Line 453: if stompClient is None: Line 454: raise RuntimeError("Failed to create a stomp client") Line 455: else: Line 456: return stompClient -- To view, visit https://gerrit.ovirt.org/38491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5ad4c79130c0ca1c4a5bd01343eafd3d8bf36231 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yaniv Bronheim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches