Francesco Romani has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

codewise looks OK, but we need to address Dan's comments about commit message.

https://gerrit.ovirt.org/#/c/41415/2//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-05-26 10:01:22 +0300
Line 4: Commit:     Shahar Havivi <[email protected]>
Line 5: CommitDate: 2015-05-31 11:21:32 +0300
Line 6: 
Line 7: RFE: Report downtime for each live migration
> this patch is a bugfix, isn't it? not RFE implementation.
Should be one bugfix of one RFE implementation :)
Line 8: 
Line 9: Libvirt report how much time the VM was off-line via jobStats.
Line 10: We fetch the downtime key which return the correct time but the source
Line 11: and dest hosts need to be in sync.


-- 
To view, visit https://gerrit.ovirt.org/41415
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1cf80f5d41dadc95b814ea567e5c313ac6f25e2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to