Yeela Kaplan has posted comments on this change. Change subject: sslutils: introduce ssl_enabled ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41795/3/lib/vdsm/tool/configurators/certificates.py File lib/vdsm/tool/configurators/certificates.py: Line 78: SYSCONF_PATH, Line 79: 'vdsm/vdsm.conf' Line 80: ) Line 81: ) Line 82: return not sslutils.ssl_enabled() or\ > doesn't pep8 expect whitespace after the or ? it didn't mention this, but I'll fix this anyway... actually it was there all along. But I'll fix it anyway. -- To view, visit https://gerrit.ovirt.org/41795 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iec301a55c02943950d5f56702ec1dd58ed954340 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
