Francesco Romani has posted comments on this change. Change subject: virt: bind console to unix domain socket ......................................................................
Patch Set 8: (1 comment) https://gerrit.ovirt.org/#/c/40704/8/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 3409: # Since: 4.17.0 Line 3410: ## Line 3411: {'type': 'VmConsoleDeviceSpecParams', Line 3412: 'data': {'consoleType': 'VmConsoleDeviceType', Line 3413: '*enableSocket': 'boolean'}} > that should be 'bool' Right. Funnily enough, my 'make check' never complained :\ Line 3414: Line 3415: ## Line 3416: # @VmConsoleDevice: Line 3417: # -- To view, visit https://gerrit.ovirt.org/40704 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a876cd7f3b848aa9dde8123d459dc292729b303 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Vitor de Lima <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
