Piotr Kliczewski has posted comments on this change. Change subject: stomp: calling super explicitly ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/41269/6/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 75: Line 76: class StompError(RuntimeError): Line 77: def __init__(self, frame): Line 78: self.frame = frame Line 79: super(RuntimeError, self).__init__(self.frame.body) > Why do we need to save the frame? When something happens someone can inspect faulty frame. Line 80: Line 81: Line 82: class _HeartBeatFrame(object): Line 83: def encode(self): -- To view, visit https://gerrit.ovirt.org/41269 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47d17beaac0b41c3dc0b2de0cf2469d6ff519426 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
