Dan Kenigsberg has posted comments on this change. Change subject: ceph: Initial support for network disk ......................................................................
Patch Set 14: (1 comment) https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json File vdsm/rpc/vdsmapi-schema.json: Line 2598: # Line 2599: # @baseVolumeID: #optional When used as a parameter to @VM.merge, indicates Line 2600: # the Volume that should become the new base volume Line 2601: # Line 2602: # @diskType: #optional Disk type name. Currently used only for network > The plan is to support also "block" and "file", so vdsm does not have to ch Unlike Federico - I'd be very happy to skip the sometimes-blocking test of block/file. Please rephrase (or add a new class of data). other than this tiny comment, this patch can be merged. Line 2603: # disks Line 2604: # Since: 4.17.0 Line 2605: # Line 2606: # @hosts: #optional List of network disk host info objects. At least -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
