Nir Soffer has posted comments on this change. Change subject: jsonrpc: ignore not needed transport ......................................................................
Patch Set 16: (1 comment) https://gerrit.ovirt.org/#/c/40173/16/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 359: else: Line 360: return ("result" in obj or "error" in obj) Line 361: Line 362: def _handleMessage(self, req): Line 363: message = req[1] > I personally like the self-documenting code, which reminds the reader what Like Dan, I prefer the current code. If we want to eliminate the unused transport, use namedtuple so we can work with req.message. Line 364: try: Line 365: mobj = json.loads(message) Line 366: isResponse = self._isResponse(mobj) Line 367: except: -- To view, visit https://gerrit.ovirt.org/40173 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icecf5c06e216151bd95f56f6fef9ed9ccba9074d Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
