Federico Simoncelli has posted comments on this change. Change subject: Specify the ACPI flag when shutting down VMs ......................................................................
Patch Set 1: (1 inline comment) .................................................... File vdsm/libvirtvm.py Line 2000: def _acpiShutdown(self): The problem is that you need to remember to install the guest agent (currently in all the VMs) and if it's missing (not started or crashed) the command is going to fail (and the VM won't shutdown). Do you know why it is preferable to use the guest agent when it's available? -- To view, visit http://gerrit.ovirt.org/6996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ca628ce6f4a5c7f6a937a14b12a5078b32e89dd Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Bing Bu Cao <m...@linux.vnet.ibm.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Gal Hammer <gham...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Royce Lv <lvro...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
