Dan Kenigsberg has posted comments on this change. Change subject: Move _stpBooleanize to netinfo. ......................................................................
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/41972/1/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 214: else: Line 215: return 'off' Line 216: Line 217: Line 218: def stpBooleanize(value): new public functions should have pep8-compliant names. Line 219: if value is None: Line 220: return False Line 221: if type(value) is bool: Line 222: return value -- To view, visit https://gerrit.ovirt.org/41972 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1b2dc96fb405c2055431209023f1cb5130e5ae5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
