Ido Barkan has posted comments on this change. Change subject: net: SetupNetworks small cleanups. ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/42022/1/vdsm/network/api.py File vdsm/network/api.py: Line 681: ne.ERR_BAD_PARAMS, "No bonding option given, nor existing " Line 682: "bond %s found." % bondName) Line 683: Line 684: Line 685: def update_underlying_device_params(attrs, bondings, _netinfo): > For me, this function makes bad things worse. The point is that its output true. it is just me posting stuff early. it should be made back private, and after our conversation I finally understood what this code _meant_ to do. Line 686: """update a specific network attributes with relevant bonding/ nic Line 687: info.""" Line 688: net_attr = dict(attrs) Line 689: if 'bonding' in net_attr: -- To view, visit https://gerrit.ovirt.org/42022 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib054e144dccbff40b40b5967dca0bf840bce8ab9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
