Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events ......................................................................
Patch Set 31: (4 comments) https://gerrit.ovirt.org/#/c/38069/31/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 288: subscribed > /s/subscribes which subscribed/subscribers Done Line 285: self._reactor) Line 286: Line 287: """ Line 288: Sends message to all subscribes which subscribed to destination. Line 289: If destination is not provided we use default destination. > destination part is quite self explanatory, I think we can remove second li Done Line 290: """ Line 291: def send(self, message, destination=_DEFAULT_RESPONSE_DESTINATION): Line 292: self.log.debug("Sending response") Line 293: try: https://gerrit.ovirt.org/#/c/38069/31/tests/jsonRpcHelper.py File tests/jsonRpcHelper.py: Line 93: Line 94: json_binding = BindingJsonRpc(jsonBridge) Line 95: json_binding.start() Line 96: Line 97: cif.json_binding = json_binding > I think it might be better to add a ctor to FakeClientIf and pass it the js Done Line 98: jsonBridge.cif = cif Line 99: Line 100: stompDetector = StompDetector(json_binding) Line 101: acceptor.add_detector(stompDetector) https://gerrit.ovirt.org/#/c/38069/31/vdsm/clientIF.py File vdsm/clientIF.py: Line 138: def notify(self, event_id, **kwargs): Line 139: """ Line 140: Send notification using provided subscription id as Line 141: event_id and a dictionary as event body. Before sending Line 142: there is notify_time added on top level to the dictionary. > Here also, The comment was requested so I think it should stay as it is. Line 143: """ Line 144: notification = Notification( Line 145: event_id, Line 146: self._send_notification, -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
