Nir Soffer has posted comments on this change. Change subject: gluster: Verify volume is Replica 3 ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/41931/1/vdsm/storage/storage_exception.py File vdsm/storage/storage_exception.py: Line 1197: Line 1198: Line 1199: class GlusterVolumeNotReplicaThreeException(StorageException): Line 1200: code = 4710 Line 1201: message = "Only Gluster volume Replica 3 is supported" > We are supporting same behavior as in hosted engine (HE) where only replica We can support more configurations, why limit the configurations supported by hosted-engine setup? Please check with gluster guys if about other valid replica values. I'm not convinced that we should support only replica 3. I'm convinced that we should not support replica 2. Line 1202: Line 1203: Line 1204: ################################################# Line 1205: # LVM related Exceptions -- To view, visit https://gerrit.ovirt.org/41931 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fee5d023706e2a0613201a9afef7d285b08442f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Ala Hino <ah...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches