Yaniv Bronhaim has posted comments on this change. Change subject: Add support for KSM and CpuTune calls to XMLRPC for MOM to use ......................................................................
Patch Set 6: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/41571/6/vdsm/API.py File vdsm/API.py: Line 1645: Line 1646: def setKsmTune(self, tuningParams): Line 1647: try: Line 1648: superVdsm = supervdsm.getProxy() Line 1649: superVdsm.ksmTune(tuningParams) so currently we have ksmTune and nobody uses it?... great Line 1650: return dict(status=doneCode) Line 1651: except: Line 1652: return errCode['ksmErr'] Line 1653: Line 1649: superVdsm.ksmTune(tuningParams) Line 1650: return dict(status=doneCode) Line 1651: except: Line 1652: return errCode['ksmErr'] Line 1653: what with the other 2 verbs that you add - vmSetCpuTuneQuota and vmSetCpuTunePeriod? can you explain in the commit message why you don't expose them as well? Line 1654: def setHaMaintenanceMode(self, mode, enabled): Line 1655: """ Line 1656: Sets Hosted Engine HA maintenance mode ('global' or 'local') to Line 1657: enabled (True) or disabled (False). -- To view, visit https://gerrit.ovirt.org/41571 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd318b50abf8605c2584cb3b5316e2ca2ac4f5ef Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
