Yaniv Bronhaim has posted comments on this change. Change subject: stomp: outgoing connection to a broker ......................................................................
Patch Set 26: (1 comment) https://gerrit.ovirt.org/#/c/38819/26/lib/yajsonrpc/stompreactor.py File lib/yajsonrpc/stompreactor.py: Line 462: self._client = client Line 463: self._reply_to = request_frame.headers.get('reply-to', None) Line 464: Line 465: def get_local_address(self, *args, **kwargs): Line 466: return "" > For getCaps we need lastClientIface. Connection object is responsible for r its the borker - you can return "vdsm broker" or the location\hostname of the broker Line 467: Line 468: def send(self, data): Line 469: if self._reply_to is None: Line 470: return -- To view, visit https://gerrit.ovirt.org/38819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Gerrit-PatchSet: 26 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
