Yeela Kaplan has posted comments on this change. Change subject: multipath-conf: Add (disabled) overrides section ......................................................................
Patch Set 1: Code-Review-1 (2 comments) I like it, except for 2 minor comments. https://gerrit.ovirt.org/#/c/42189/1/lib/vdsm/tool/configurators/multipath.py File lib/vdsm/tool/configurators/multipath.py: Line 48: max_fds 4096 Line 49: } Line 50: Line 51: devices { Line 52: # Remove devices entries when overrides section is available. Please add the keyword: TODO And move it before the devices section,so it will be more clear what it refers to. Line 53: device { Line 54: # multipath.conf.default Line 55: vendor "HITACHI" Line 56: product "DF.*" Line 93: features "0" Line 94: no_path_retry fail Line 95: } Line 96: } Line 97: Also add keyword: TODO Line 98: # Enable when this section is available on all supported platforms. Line 99: # Options defined here override device specific options embedded into Line 100: # multipathd. Line 101: # -- To view, visit https://gerrit.ovirt.org/42189 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I204db18c33f8cd3ef37fc4e9fa02edc0fd3ec963 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
