Ondřej Svoboda has posted comments on this change. Change subject: net: introducing KernelConfig ......................................................................
Patch Set 5: Code-Review-1 (4 comments) Just some quick notes. Good luck with the patch (and link-local addresses)! :-) https://gerrit.ovirt.org/#/c/41973/5/lib/vdsm/netconfpersistence.py File lib/vdsm/netconfpersistence.py: Line 231: self._get_bootproto(net_attr) 'dhcp' in net_attr['dhcpv4'] else 'none' is sufficient here so the (incorrect, see below) function _get_bootproto can be removed. Line 394: net_attr['dhcpv4'] or net_attr['dhcpv6'] 'bootproto' has never meant DHCPv6 so if this function were to stay the condition would have to be just net_attr['dhcpv4'] https://gerrit.ovirt.org/#/c/41973/5/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 925: @staticmethod I would prefer not to have simple accessor functions :-) https://gerrit.ovirt.org/#/c/41973/5/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 425: status, msg = self.setupNetworks(networks, bondings, NOCHK) Did I understand from comments on the previous patch set that you are going to move these changes to a separate, simple patch? Thank you if you do so, it would make looking for real changes easier :-) -- To view, visit https://gerrit.ovirt.org/41973 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I79f1eb553a42f1398ad12aa1bc33522f8af30c79 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
