Piotr Kliczewski has posted comments on this change. Change subject: events: vm status notifications ......................................................................
Patch Set 27: (1 comment) https://gerrit.ovirt.org/#/c/38937/27/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 377: self.saveState() Line 378: self._lastStatus = value Line 379: Line 380: def send_status_event(self): Line 381: vm_status = self._getVmStatus()['status'] > This comparison is (abviously) raceful. I understand that we do not care, a Done Line 382: if vm_status != self._evaluatedStatus: Line 383: self._evaluatedStatus = vm_status Line 384: stats = { Line 385: 'status': vm_status, -- To view, visit https://gerrit.ovirt.org/38937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Dima Kuznetsov <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
