Dan Kenigsberg has submitted this change and it was merged. Change subject: ceph: Validate network disk parameters ......................................................................
ceph: Validate network disk parameters If hosts or protocol are missing, raise ValueError during getXML validation. This is little nicer to debug then KeyError when value was not set, and avoid creation of invalid xml when specified value is empty. Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d Signed-off-by: Nir Soffer <[email protected]> Reviewed-on: https://gerrit.ovirt.org/40477 Reviewed-by: Francesco Romani <[email protected]> Reviewed-by: Daniel Erez <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Federico Simoncelli <[email protected]> Reviewed-by: Adam Litke <[email protected]> --- M tests/vmStorageTests.py M vdsm/virt/vmdevices/storage.py 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Federico Simoncelli: Looks good to me, approved Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, but someone else must approve Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/40477 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b10c54ba2732ee75e0e55c67e5e8c7bdfafa41d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Ala Hino <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Freddy Rolland <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
