Dan Kenigsberg has submitted this change and it was merged. Change subject: force absolute imports where we can ......................................................................
force absolute imports where we can Implicit relative imports are confusing, as explained in https://www.python.org/dev/peps/pep-0328/. They have been dropped from Python 3, too. Unfortunately, we still use them extensively, but our lib and vdsm/network directories are almost free of them. This patch drops a single occurrence and makes sure that we do not happen to add new implicit relative imports by mistake under thess directories. Future patches would extend the white list until Vdsm is free of them. Change-Id: Ibb3aed51c37b846c928fc2d443c9f848dcba5d7c Signed-off-by: Dan Kenigsberg <[email protected]> Reviewed-on: https://gerrit.ovirt.org/42045 Reviewed-by: Piotr Kliczewski <[email protected]> Reviewed-by: Adam Litke <[email protected]> Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer <[email protected]> --- M Makefile.am M lib/vdsm/__init__.py M lib/vdsm/cmdutils.py M lib/vdsm/compat.py M lib/vdsm/concurrent.py M lib/vdsm/config.py.in M lib/vdsm/constants.py.in M lib/vdsm/define.py M lib/vdsm/exception.py M lib/vdsm/executor.py M lib/vdsm/infra/__init__.py M lib/vdsm/infra/eventfd/__init__.py M lib/vdsm/infra/eventfd/tests.py M lib/vdsm/infra/filecontrol/__init__.py M lib/vdsm/infra/filecontrol/tests.py M lib/vdsm/infra/sigutils/__init__.py M lib/vdsm/infra/sigutils/tests.py M lib/vdsm/infra/sigutils/tests_child.py M lib/vdsm/infra/zombiereaper/__init__.py M lib/vdsm/infra/zombiereaper/tests.py M lib/vdsm/ipwrapper.py M lib/vdsm/libvirtconnection.py M lib/vdsm/netconfpersistence.py M lib/vdsm/netinfo.py M lib/vdsm/netlink/__init__.py M lib/vdsm/netlink/addr.py M lib/vdsm/netlink/link.py M lib/vdsm/netlink/monitor.py M lib/vdsm/netlink/route.py M lib/vdsm/password.py M lib/vdsm/profiling/__init__.py M lib/vdsm/profiling/cpu.py M lib/vdsm/profiling/errors.py M lib/vdsm/profiling/memory.py M lib/vdsm/profiling/profile.py M lib/vdsm/pthread.py M lib/vdsm/qemuimg.py M lib/vdsm/response.py M lib/vdsm/schedule.py M lib/vdsm/sslutils.py M lib/vdsm/sysctl.py M lib/vdsm/tool/__init__.py M lib/vdsm/tool/configfile.py M lib/vdsm/tool/configurator.py M lib/vdsm/tool/configurators/__init__.py M lib/vdsm/tool/configurators/certificates.py M lib/vdsm/tool/configurators/libvirt.py M lib/vdsm/tool/configurators/multipath.py M lib/vdsm/tool/configurators/passwd.py M lib/vdsm/tool/configurators/sanlock.py M lib/vdsm/tool/configurators/sebool.py M lib/vdsm/tool/dummybr.py M lib/vdsm/tool/dump_bonding_defaults.py M lib/vdsm/tool/dump_volume_chains.py M lib/vdsm/tool/load_needed_modules.py.in M lib/vdsm/tool/nwfilter.py M lib/vdsm/tool/register.py M lib/vdsm/tool/restore_nets.py M lib/vdsm/tool/service.py M lib/vdsm/tool/transient.py M lib/vdsm/tool/unified_persistence.py M lib/vdsm/tool/upgrade.py M lib/vdsm/tool/validate_ovirt_certs.py.in M lib/vdsm/tool/vdsm-id.py M lib/vdsm/udevadm.py M lib/vdsm/utils.py M lib/vdsm/vdscli.py M lib/vdsm/virtsparsify.py M lib/vdsm/xmlrpc.py M lib/yajsonrpc/__init__.py M lib/yajsonrpc/betterAsyncore.py M lib/yajsonrpc/stomp.py M lib/yajsonrpc/stompreactor.py M vdsm/network/__init__.py M vdsm/network/api.py M vdsm/network/configurators/__init__.py M vdsm/network/configurators/dhclient.py M vdsm/network/configurators/ifcfg.py M vdsm/network/configurators/iproute2.py M vdsm/network/configurators/libvirt.py M vdsm/network/configurators/pyroute_two.py M vdsm/network/configurators/qos.py M vdsm/network/errors.py M vdsm/network/models.py M vdsm/network/sourceroute.py M vdsm/network/sourceroutethread.py M vdsm/network/tc/__init__.py M vdsm/network/tc/_parser.py M vdsm/network/tc/_wrapper.py M vdsm/network/tc/cls.py M vdsm/network/tc/filter.py M vdsm/network/tc/qdisc.py 92 files changed, 105 insertions(+), 3 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Looks good to me, but someone else must approve Adam Litke: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/42045 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb3aed51c37b846c928fc2d443c9f848dcba5d7c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
