Dan Kenigsberg has submitted this change and it was merged.

Change subject: ceph: Add libvirt secret testing infrastructure
......................................................................


ceph: Add libvirt secret testing infrastructure

New vmfakelib.Error function create a libvirt.libvirtError with specific
error code, for testing code that must handle certain libvirt errors.

vmfakelib.Connection supports now secret related methods:

- secretDefineXML
- secretLookupByUUIDString

New vmfakelibTests module added to verify that the fakes are behaving
like the real libvirt objects.

Change-Id: Iac2d4ebaf8cadeff2818b2eac593b8d28b5d6706
Signed-off-by: Nir Soffer <[email protected]>
Reviewed-on: https://gerrit.ovirt.org/40789
Reviewed-by: Francesco Romani <[email protected]>
Reviewed-by: Adam Litke <[email protected]>
Continuous-Integration: Jenkins CI
Reviewed-by: Federico Simoncelli <[email protected]>
---
M tests/Makefile.am
M tests/vmfakelib.py
A tests/vmfakelibTests.py
3 files changed, 236 insertions(+), 2 deletions(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40789
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iac2d4ebaf8cadeff2818b2eac593b8d28b5d6706
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: [email protected]
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to