Ayal Baron has posted comments on this change. Change subject: Add deathSignal options to better peopen ......................................................................
Patch Set 9: Looks good to me, but someone else must approve (4 inline comments) .................................................... Commit Message Line 7: Add deathSignal options to better peopen s/peopen/popen/ .................................................... File vdsm/betterPopen/__init__.py Line 37: # deathDignal is the signal that will be sent to the child process s/Dignal/Signal Line 39: # popen and when using standard peopen we should make sure we s/peopen/popen/ Line 40: # reimplement this. have you suggested this in upstream python? -- To view, visit http://gerrit.ovirt.org/6241 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f987129cea112e2a75d6f02477369417cc50dc7 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
